Skip to content

update @babel/runtime to not be a pinned specific version - #538

Merged
mansona merged 2 commits into
masterfrom
runtime
Aug 21, 2026
Merged

update @babel/runtime to not be a pinned specific version#538
mansona merged 2 commits into
masterfrom
runtime

Conversation

@mansona

@mansona mansona commented Aug 20, 2026

Copy link
Copy Markdown
Member

This PR will remove the vulnerability report from ember-cli-babel, or at least we could easily fix it in a follow up PR 👍

Edit: it seems that the floating dependency issue has nothing to do with this PR 🤔 it looks like it's related to execa

@mansona mansona mentioned this pull request Aug 20, 2026
@mansona mansona added the bug label Aug 20, 2026
@mansona
mansona requested a review from a team August 20, 2026 23:17
@NullVoxPopuli

Copy link
Copy Markdown
Contributor

floating deps are red

- errorMessage: require() of ES Module 
  /home/runner/work/ember-cli-babel/ember-cli-babel/node_modules/.pnpm/execa@9.6.1/node_modules/execa/index.js 
  from /home/runner/work/ember-cli-babel/ember-cli-babel/node_modules/.pnpm/testem@3.20.1_@babel+core@7.29.7/node_modules/testem/lib/utils/fileutils.js 
  not supported.

Instead change the require of index.js in /home/runner/work/ember-cli-babel/ember-cli-babel/node_modules/.pnpm/testem@3.20.1_@babel+core@7.29.7/node_modules/testem/lib/utils/fileutils.js 
to a dynamic import() which is available in all CommonJS modules.

so, floating deps ci needs a node upgrade+?
(is that breaking for this package? I don't know if the node policy is the same as the ember-proper libraries)

@mansona

mansona commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

this is just a bug in testem where they merged a breaking change as a minor, I tried to tell them that they shouldn't do that but the discussion thread was locked and the main maintainer was not for listening any more

@mansona

mansona commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

If we merge this then all the floating deps CI jobs start working again: #539

@mansona
mansona merged commit 353b4ad into master Aug 21, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants