fix: Add GPT-6 Astra to DeepNews model typing - #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
gpt-6-astrato the directDeepNewsModeltype used by sync and asyncget_deep_news().Why
Align the hand-written SDK's direct DeepNews typing with the approved model rollout without changing request serialization, defaults, documentation, or Alerts behavior.
How I tested
ruff check asknews_sdk(the command underlyingtask lint;taskwas unavailable in the execution environment)coverage run -m pytest --junitxml=report.xml, plus coverage report/XML/HTML generation (the commands underlyingtask test; 94 passed)git diff --checkgitlint --commits HEAD~1..HEADRisk / rollback
Low: this is a typing-only catalog addition plus regression tests. No DTO, default, README, CHANGELOG, package-version, Alerts, or workflow files changed. This branch and PR trigger CI checks only; no release action is performed. A human merge to
mainwould invoke the SDK's automated patch-release flow because the commit isfix:. Revert the commit to roll back.