Conversation
(cherry picked from commit 3e3a583)
hxy7yx
approved these changes
Apr 29, 2026
Author
|
Thanks @hxy7yx for the review and approval — ready when you have a moment to merge. |
Author
|
Thanks @hxy7yx for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two-line strcpy→strncpy swap in
handle_add_pluginandhandle_update_pluginto bound the copy intocmd.library[NEU_PLUGIN_LIBRARY_LEN].Upstream 3e3a583 also interleaves the new
header.otel_trace_typetelemetry field (introduced with OTEL tracing support later on master). Since v2.9 has no OTEL tracing yet, I kept the surrounding struct init as-is and only applied the security change.NEU_PLUGIN_LIBRARY_LENis already defined on v2.9 atinclude/neuron/define.h:43.Fix originally by @xiang.zhou, preserved via
cherry-pick -x.