Conversation
(cherry picked from commit 3e3a583)
hxy7yx
approved these changes
Apr 29, 2026
Author
|
Appreciated, @hxy7yx — confirmed mergeable=True on this one. Happy to coordinate timing. |
Author
|
Appreciate the approval, @hxy7yx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting the same two
strcpy → strncpy(..., NEU_PLUGIN_LIBRARY_LEN)swaps from 3e3a583 to the v2.7 line. Context is identical to master's; the only piece of the original diff that doesn't apply here is theheader.otel_trace_type = NEU_OTEL_TRACE_TYPE_REST_COMMassignment — OTEL tracing was added after v2.7 so that field isn't defined onneu_reqresp_head_tyet. Dropped it; kept just the buffer-bounding change.Net: 2 lines, both on the strncpy swap. Author credit to xiang.zhou via
-x.