Skip to content

docs: fix stale facts in CLAUDE.md files - #144

Open
smini-digital wants to merge 1 commit into
mainfrom
claude/claude-md-audit-fixes
Open

smini-digital wants to merge 1 commit into
mainfrom
claude/claude-md-audit-fixes

Conversation

@smini-digital

Copy link
Copy Markdown
Contributor

Summary

Fixes stale facts in this repo's Claude Code instruction files (CLAUDE.md), found by a prompt audit of the NegSoft agent configuration. Docs only — no code changes. Most nested files were bulk-generated and have drifted from the code: they name files, flags, versions or APIs that no longer exist, and agents reading them copy the wrong example.

No ticket — authorized no-ticket cleanup.

Fixed (3)

  • llm-cli-setup/CLAUDE.md:10,19,28 bare package name: The name is @enthus-appdev/llm-cli-setup.
  • llm-cli-setup/CLAUDE.md:48 findBinary(): The functions are still per-tool findBinary.
  • llm-cli-setup/CLAUDE.md:12,14,68 CRITICAL/BOTH/ALL

Testing

Every claim was re-verified against main@9fb45b9 by reading the repo (paths, exported names, package.json / go.mod / flag definitions, workflows) before it went into the diff; no command named in the docs was run. git apply --check is clean on main@9fb45b9. The diff touches only CLAUDE.md / AGENTS.md files.

@smini-digital smini-digital self-assigned this Oct 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CLAUDE.md documentation to use the scoped package name @enthus-appdev/llm-cli-setup instead of llm-cli-setup. It also refines the documentation by clarifying the binary finder function naming convention to findBinary() and softening some of the emphatic phrasing. There are no review comments, and I have no feedback to provide.

@smini-digital

Copy link
Copy Markdown
Contributor Author

🔏 Readiness attested — the pr-readiness-check gate completed for PR #144 at c7648da9a494ef5375ee33e7fe23b5292620e0fc (2026-10-30T10:11:26Z). If the branch head has moved, this evidence covers the earlier state only.

Readiness summary

PR Readiness Check (#144, c7648da)
Review mode INITIAL
Branch/base PASS
Local verification SKIP (operator-waived: docs-only)
Remote CI PASS — NPM (Check format, Lint) and CodeQL success; DEFERRED UNTIL READY — License NPM
Coverage NOT REPORTED
Automated reviewers PASS — current-head Gemini review, no threads
Review threads PASS (0 unresolved)
Review comments PASS (open-review-comments.sh exit 0)
Council findings SKIP (operator-waived: docs-only) — files: CLAUDE.md
Standards review SKIP (same waiver)
Spec review SKIP (same waiver)
PR description PASS
SQL/UI evidence SKIP
Result: READY

@smini-digital
smini-digital marked this pull request as ready for review October 30, 2026 10:11
@fank

fank commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Ratatoskr reviewed this pull request.

Approved on c7648da9. See the review.

Finished 2026-10-30 10:49 UTC.

@fank fank left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — 0 blocking findings.

Review details

Reviewed commit c7648da9a494ef5375ee33e7fe23b5292620e0fc against 9fb45b92594f88a368ab9c80d1c1f51b995c1faa.

The scoped imports and linking target in CLAUDE.md:10,19,28 match package.json's package name and library export. The finder naming at CLAUDE.md:48 matches existing helpers such as findEsqBinary and findAtlBinary. The entry-point and new-tool checklist requirements remain intact after the wording changes. Only CLAUDE.md changed; no runtime or safety defects identified.

Verification: inspected the PR diff and relevant package/installer/library source; git diff --check 9fb45b92594f88a368ab9c80d1c1f51b995c1faa HEAD passed. Local runtime tests were not run for this documentation-only change. GitHub reports successful lint, format, CodeQL, and license checks (one additional license job skipped).

Discussions: authenticated reviewer is fank. GraphQL returned no review threads, with no further pages; none to resolve, continue, or skip.

@smini-digital

Copy link
Copy Markdown
Contributor Author

Ratatoskr status comment #issuecomment-6520848696: approved with 0 findings; nothing to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants