Repository navigation
docs: fix stale facts in CLAUDE.md files - #144
smini-digital wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the CLAUDE.md documentation to use the scoped package name @enthus-appdev/llm-cli-setup instead of llm-cli-setup. It also refines the documentation by clarifying the binary finder function naming convention to findBinary() and softening some of the emphatic phrasing. There are no review comments, and I have no feedback to provide.
|
🔏 Readiness attested — the Readiness summaryPR Readiness Check (#144, c7648da) |
|
Ratatoskr reviewed this pull request. Approved on Finished 2026-10-30 10:49 UTC. |
fank
left a comment
There was a problem hiding this comment.
APPROVE — 0 blocking findings.
Review details
Reviewed commit c7648da9a494ef5375ee33e7fe23b5292620e0fc against 9fb45b92594f88a368ab9c80d1c1f51b995c1faa.
The scoped imports and linking target in CLAUDE.md:10,19,28 match package.json's package name and library export. The finder naming at CLAUDE.md:48 matches existing helpers such as findEsqBinary and findAtlBinary. The entry-point and new-tool checklist requirements remain intact after the wording changes. Only CLAUDE.md changed; no runtime or safety defects identified.
Verification: inspected the PR diff and relevant package/installer/library source; git diff --check 9fb45b92594f88a368ab9c80d1c1f51b995c1faa HEAD passed. Local runtime tests were not run for this documentation-only change. GitHub reports successful lint, format, CodeQL, and license checks (one additional license job skipped).
Discussions: authenticated reviewer is fank. GraphQL returned no review threads, with no further pages; none to resolve, continue, or skip.
|
Ratatoskr status comment #issuecomment-6520848696: approved with 0 findings; nothing to change. |
Summary
Fixes stale facts in this repo's Claude Code instruction files (
CLAUDE.md), found by a prompt audit of the NegSoft agent configuration. Docs only — no code changes. Most nested files were bulk-generated and have drifted from the code: they name files, flags, versions or APIs that no longer exist, and agents reading them copy the wrong example.No ticket — authorized no-ticket cleanup.
Fixed (3)
Testing
Every claim was re-verified against
main@9fb45b9by reading the repo (paths, exported names,package.json/go.mod/ flag definitions, workflows) before it went into the diff; no command named in the docs was run.git apply --checkis clean onmain@9fb45b9. The diff touches onlyCLAUDE.md/AGENTS.mdfiles.