Skip to content

Fix keymap help float to respect NormalFloat styling - #560

Merged
esmuellert merged 2 commits into
mainfrom
copilot/fix-floating-keymap-help-window
Sep 11, 2026
Merged

Fix keymap help float to respect NormalFloat styling#560
esmuellert merged 2 commits into
mainfrom
copilot/fix-floating-keymap-help-window

Conversation

Copilot AI commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

The keymap help floating window body was rendered with Normal instead of NormalFloat, causing theme-inconsistent appearance for users with customized float highlight groups. This change aligns the help popup body highlight with standard floating window styling.

  • Highlight mapping fix

    • Updated the keymap help float winhighlight to map NormalFloat to NormalFloat (instead of Normal), so the popup body inherits expected float colors.
  • Regression coverage

    • Added a focused spec to assert the help window opens with winhighlight = "NormalFloat:NormalFloat".
-- before
vim.wo[win].winhighlight = "NormalFloat:Normal"

-- after
vim.wo[win].winhighlight = "NormalFloat:NormalFloat"

Co-authored-by: esmuellert <41042490+esmuellert@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix floating keymap help window to respect NormalFloat Fix keymap help float to respect NormalFloat styling Sep 10, 2026
Copilot AI requested a review from esmuellert September 10, 2026 20:56
@esmuellert
esmuellert marked this pull request as ready for review September 10, 2026 23:57
@esmuellert
esmuellert requested a review from yanuoma as a code owner September 10, 2026 23:57
@esmuellert
esmuellert disabled auto-merge September 11, 2026 00:52
@esmuellert
esmuellert merged commit 589d26f into main Sep 11, 2026
19 of 20 checks passed
@esmuellert
esmuellert deleted the copilot/fix-floating-keymap-help-window branch September 11, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] floating keymap help window doesn't respect NormalFloat (1 line fix)

2 participants