Skip to content

Find author class among multiple classes on span #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JimKnoxx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Find author class among multiple classes on span #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions static/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ const showAuthor = {
show: (span) => {
if (clientVars.plugins.plugins.ep_author_hover.enabled) {
const authorTarget = $(span.target).closest('span')[0];
if (!authorTarget) { return; } // We might not be over a valid target
if (!authorTarget) return; // We might not be over a valid target
// Find the nearest span with an author class (may be target itself or a parent/child)
const authorId = showAuthor.authorIdFromClass(authorTarget.className); // Get the authorId
if (!authorId) { return; } // Default text isn't shown
showAuthor.destroy(); // Destroy existing
Expand All @@ -38,8 +39,15 @@ const showAuthor = {
}
},
authorIdFromClass: (className) => {
if (className.substring(0, 7) === 'author-') {
return className.substring(7).replace(/[a-y0-9]+|-|z.+?z/g, (cc) => {
// className may contain multiple classes (e.g. "comment c-123 author-a.xyz").
// Find the one starting with "author-".
const classes = className.split(/\s+/);
let authorClass = null;
for (const cls of classes) {
if (cls.indexOf('author-') === 0) { authorClass = cls; break; }
}
if (authorClass) {
return authorClass.substring(7).replace(/[a-y0-9]+|-|z.+?z/g, (cc) => {
if (cc === '-') { return '.'; } else if (cc.charAt(0) === 'z') {
return String.fromCharCode(Number(cc.slice(1, -1)));
} else {
Expand Down