Bael 7805 how to fix json io exception failed making field property accessible in gson - #19293
Open
MBuczkowski2025 wants to merge 15 commits into
Conversation
theangrydev
requested changes
Aug 13, 2026
theangrydev
requested changes
Aug 13, 2026
theangrydev
requested changes
Aug 24, 2026
theangrydev
requested changes
Aug 24, 2026
theangrydev
requested changes
Sep 2, 2026
theangrydev
left a comment
theangrydev
left a comment
Collaborator
There was a problem hiding this comment.
Minor formatting points remaining, otherwise done with PR
Comment on lines
+15
to
+38
| @Test | ||
| void givenModularAndExportedPackage_whenDeserializingPojo_thenJsonIOException() { | ||
| String json = """ | ||
| { | ||
| "name": "Java Conference", | ||
| "numberOfParticipants": 150 | ||
| } | ||
| """; | ||
| Gson gson = new Gson(); | ||
|
|
||
| assertThrows(JsonIOException.class, () -> { | ||
| gson.fromJson(json, ConferencePojo.class); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| void givenModularAndExportedPackage_whenDeserializingRecord_thenSuccess() { | ||
| String json = """ | ||
| { | ||
| "name": "Java Conference", | ||
| "numberOfParticipants": 150 | ||
| } | ||
| """; | ||
| Gson gson = new Gson(); |
Collaborator
There was a problem hiding this comment.
We're still formatting things differently between tests - can we align the formatting to be consistent throughout - it's distracting for a reader to see different formatting and have to try and figure out if there's any real difference or just a formatting difference
Comment on lines
+19
to
+21
| name:"Java Conference", | ||
| numberOfParticipants:500, | ||
| conferenceStart:{"year":2026,"month":8,"day":17} |
Collaborator
There was a problem hiding this comment.
We are missing "" around the fields here - this is only working by accident because Gson has lenient parsing by default
And please normalise the formatting to the standard indentation style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.