Repository navigation
refactor(deps): remove unused dependency edges - #1639
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | ef58d23 | Commit Preview URL | May 21 2026, 01:57 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Remove unused dependency edges and replace two small dependency-backed helpers with local implementations. ## Why Reduce dependency surface and keep stable tool schemas independent of proc-macro schema generation. ## How - Removed unused direct dependencies from manifests and locks: `schemars`, `russh-keys`, CLI `serde`/`serde_json`, JS `serde`. - Replaced `url::form_urlencoded` calls in the HTTP builtin with a local x-www-form-urlencoded encoder and tightened tests. - Replaced `schemars::schema_for!(ToolRequest/ToolResponse)` with manual stable JSON schemas reused by BashTool and scripted tools. - Updated threat-model wording and supply-chain exemptions to match the new dependency graph. ## Risk - Low - Manual schemas could drift if `ToolRequest` or `ToolResponse` changes without updating the schema helper. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered - [x] Security review performed against relevant threat model categories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove unused dependency edges and replace two small dependency-backed helpers with local implementations.
Why
Reduce dependency surface and keep stable tool schemas independent of proc-macro schema generation.
How
schemars,russh-keys, CLIserde/serde_json, JSserde.url::form_urlencodedcalls in the HTTP builtin with a local x-www-form-urlencoded encoder and tightened tests.schemars::schema_for!(ToolRequest/ToolResponse)with manual stable JSON schemas reused by BashTool and scripted tools.Risk
ToolRequestorToolResponsechanges without updating the schema helper.Checklist