Skip to content

feat(rg): add path separator output - #1660

Merged
chaliy merged 1 commit into
mainfrom
2026-05-22-rg-path-separator
May 22, 2026
Merged

chaliy merged 1 commit into
mainfrom
2026-05-22-rg-path-separator

Conversation

@chaliy

@chaliy chaliy commented May 22, 2026

Copy link
Copy Markdown
Contributor

What

Add rg --path-separator support for displayed paths.

Why

Real rg lets callers choose the path separator used in filename output and --files output.

How

Validate separators as exactly one byte, rewrite displayed rg paths after path formatting, and add real-rg differential cases for explicit files, dot-relative paths, and --files output.

Risk

  • Low
  • Scoped to rg display paths.

Checklist

  • Tests added or updated
  • Backward compatibility considered

Verification:

  • cargo test -p bashkit builtins::rg::tests -- --nocapture
  • just pre-pr

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bashkit 2634151 Commit Preview URL May 22 2026, 06:37 AM

@chaliy
chaliy merged commit dfed6c4 into main May 22, 2026
34 checks passed
@chaliy
chaliy deleted the 2026-05-22-rg-path-separator branch May 22, 2026 06:49
chaliy added a commit that referenced this pull request May 30, 2026
## What
Add rg --path-separator support for displayed paths.

## Why
Real rg lets callers choose the path separator used in filename output
and --files output.

## How
Validate separators as exactly one byte, rewrite displayed rg paths
after path formatting, and add real-rg differential cases for explicit
files, dot-relative paths, and --files output.

## Risk
- Low
- Scoped to rg display paths.

## Checklist
- [x] Tests added or updated
- [x] Backward compatibility considered

Verification:
- cargo test -p bashkit builtins::rg::tests -- --nocapture
- just pre-pr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant