Repository navigation
feat(rg): add engine and mmap flags - #1661
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 3d51c90 | Commit Preview URL | May 22 2026, 06:57 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add rg parser/help/docs support for regex engine and mmap control flags: -P/--pcre2, --no-pcre2, --engine, --auto-hybrid-regex, --no-auto-hybrid-regex, --mmap, and --no-mmap. ## Why These are common real ripgrep flags. For simple searches they should be accepted and match real rg output instead of failing as unknown options. ## How Treat engine and mmap controls as execution-strategy no-ops for the currently supported regex path, validate --engine values, add -P combined short parsing, and expand real-rg differential cases. ## Risk - Low - Regex engine flags are no-ops for now, so PCRE2-only pattern features still are not implemented. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add rg parser/help/docs support for regex engine and mmap control flags: -P/--pcre2, --no-pcre2, --engine, --auto-hybrid-regex, --no-auto-hybrid-regex, --mmap, and --no-mmap.
Why
These are common real ripgrep flags. For simple searches they should be accepted and match real rg output instead of failing as unknown options.
How
Treat engine and mmap controls as execution-strategy no-ops for the currently supported regex path, validate --engine values, add -P combined short parsing, and expand real-rg differential cases.
Risk
Checklist