Repository navigation
feat(rg): add crlf mode - #1663
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 8d145e4 | Commit Preview URL | May 22 2026, 07:43 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add rg --crlf / --no-crlf support so CRLF input can match anchors before the carriage return while preserving original CRLF output. ## Why Real ripgrep supports CRLF-aware matching. Bashkit rg previously stripped CR before matching unconditionally, which diverged from real rg for patterns like needle$. ## How - Track a CRLF option in rg parsing and help text. - Split line display text from match text, preserving CR for output while stripping it only for --crlf matching. - Apply replacements against the match view and reattach the display suffix. - Add data-driven real-rg differential cases for default behavior, --crlf, --no-crlf ordering, output preservation, and replacement. ## Risk - Low - Touches rg line matching/output formatting; covered by focused rg tests, real-rg differential tests, and full pre-pr. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add rg --crlf / --no-crlf support so CRLF input can match anchors before the carriage return while preserving original CRLF output.
Why
Real ripgrep supports CRLF-aware matching. Bashkit rg previously stripped CR before matching unconditionally, which diverged from real rg for patterns like needle$.
How
Risk
Checklist