Repository navigation
feat(rg): add max-filesize filtering - #1667
Merged
Merged
Conversation
chaliy
marked this pull request as ready for review
May 22, 2026 09:16
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | c4ab6db | Commit Preview URL | May 22 2026, 09:17 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add rg `--max-filesize` support for recursive discovery and `--files` listing, including `K`, `M`, and `G` suffix parsing. ## Why Real ripgrep uses `--max-filesize` as a discovery filter for recursively found files. Bashkit rg should accept and match this common flag. ## How - Parse `--max-filesize NUM` with real-rg-style byte/K/M/G units. - Filter recursive file candidates by VFS metadata size. - Bypass indexed search when this filter is active so size filtering is authoritative. - Add real-rg differential cases for recursive search, suffixes, explicit-file parity, `--files`, and empty filtered listings. ## Risk - Low - Could affect rg recursive file discovery when size metadata is inaccurate. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add rg
--max-filesizesupport for recursive discovery and--fileslisting, includingK,M, andGsuffix parsing.Why
Real ripgrep uses
--max-filesizeas a discovery filter for recursively found files. Bashkit rg should accept and match this common flag.How
--max-filesize NUMwith real-rg-style byte/K/M/G units.--files, and empty filtered listings.Risk
Checklist