Skip to content

feat(rg): add ignore file control flags - #1668

Merged
chaliy merged 1 commit into
mainfrom
2026-05-22-rg-ignore-file-flags
May 22, 2026
Merged

chaliy merged 1 commit into
mainfrom
2026-05-22-rg-ignore-file-flags

Conversation

@chaliy

@chaliy chaliy commented May 22, 2026

Copy link
Copy Markdown
Contributor

What

Add rg ignore-file control support: .rgignore, --no-ignore-files/--ignore-files, and case-insensitive ignore-file parsing flags.

Why

These are common real ripgrep ignore controls. Bashkit rg already handled .ignore, .gitignore, and explicit --ignore-file; this closes the related flag gaps.

How

  • Track explicit ignore-file enable/disable separately from --no-ignore.
  • Load .rgignore with .ignore under dot-ignore behavior.
  • Compile ignore globs case-insensitively when requested.
  • Expand real-rg differential cases and focused unit tests for flag behavior.

Risk

  • Low
  • Recursive rg search candidate filtering changes where .rgignore files are present or explicit ignore files are disabled.

Checklist

  • Tests added or updated
  • Backward compatibility considered

@chaliy
chaliy marked this pull request as ready for review May 22, 2026 09:37
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bashkit 1f64815 Commit Preview URL May 22 2026, 09:37 AM

@chaliy
chaliy merged commit f0b8bb1 into main May 22, 2026
34 checks passed
@chaliy
chaliy deleted the 2026-05-22-rg-ignore-file-flags branch May 22, 2026 09:50
chaliy added a commit that referenced this pull request May 30, 2026
## What
Add rg ignore-file control support: `.rgignore`,
`--no-ignore-files`/`--ignore-files`, and case-insensitive ignore-file
parsing flags.

## Why
These are common real ripgrep ignore controls. Bashkit rg already
handled `.ignore`, `.gitignore`, and explicit `--ignore-file`; this
closes the related flag gaps.

## How
- Track explicit ignore-file enable/disable separately from
`--no-ignore`.
- Load `.rgignore` with `.ignore` under dot-ignore behavior.
- Compile ignore globs case-insensitively when requested.
- Expand real-rg differential cases and focused unit tests for flag
behavior.

## Risk
- Low
- Recursive rg search candidate filtering changes where `.rgignore`
files are present or explicit ignore files are disabled.

## Checklist
- [x] Tests added or updated
- [x] Backward compatibility considered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant