Repository navigation
feat(rg): add max depth aliases - #1669
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 9cb7a56 | Commit Preview URL | May 22 2026, 09:58 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add real-rg-compatible max-depth aliases for the rg builtin. ## Why Real rg accepts `-d NUM`, attached short forms like `-d1`, and `--maxdepth` as aliases for `--max-depth`. Bashkit only accepted `--max-depth`. ## How - Parse `-d`, attached short `-dNUM`, combined short groups ending in `dNUM`, and `--maxdepth`. - Keep all forms wired to the existing recursive depth filter. - Add real-rg differential coverage for search output and `--files` output. - Update `rg --help` output assertions for the aliases. ## Risk - Low - Scoped to rg option parsing and help text. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered - [x] `cargo fmt && cargo test -p bashkit builtins::rg::tests -- --nocapture` - [x] `just pre-pr`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add real-rg-compatible max-depth aliases for the rg builtin.
Why
Real rg accepts
-d NUM, attached short forms like-d1, and--maxdepthas aliases for--max-depth. Bashkit only accepted--max-depth.How
-d, attached short-dNUM, combined short groups ending indNUM, and--maxdepth.--filesoutput.rg --helpoutput assertions for the aliases.Risk
Checklist
cargo fmt && cargo test -p bashkit builtins::rg::tests -- --nocapturejust pre-pr