Repository navigation
feat(rg): add ignore toggle parity - #1670
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 6d87b00 | Commit Preview URL | May 22 2026, 10:18 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add more real-rg-compatible ignore controls to the rg builtin. ## Why Real rg supports positive `--ignore*` flags to re-enable ignore classes after `--no-ignore*`, and it respects repository-local `.git/info/exclude`. Bashkit only had a subset of the negative toggles. ## How - Track dot, VCS, local exclude, global, and parent ignore toggles separately. - Add `--ignore`, `--ignore-dot`, `--ignore-vcs`, `--ignore-exclude`, `--ignore-global`, and `--ignore-parent` parsing. - Load `.git/info/exclude` under the VCS and exclude ignore gates. - Extend real-rg differential cases for default excludes, disable/reenable toggles, and partial re-enable after `--no-ignore`. - Update `rg --help` coverage for the new flags. ## Risk - Low / Medium - Scoped to rg recursive filtering. Explicit file searches still bypass ignore filtering as before. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered - [x] `cargo fmt && cargo test -p bashkit builtins::rg::tests -- --nocapture` - [x] `just pre-pr`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add more real-rg-compatible ignore controls to the rg builtin.
Why
Real rg supports positive
--ignore*flags to re-enable ignore classes after--no-ignore*, and it respects repository-local.git/info/exclude. Bashkit only had a subset of the negative toggles.How
--ignore,--ignore-dot,--ignore-vcs,--ignore-exclude,--ignore-global, and--ignore-parentparsing..git/info/excludeunder the VCS and exclude ignore gates.--no-ignore.rg --helpcoverage for the new flags.Risk
Checklist
cargo fmt && cargo test -p bashkit builtins::rg::tests -- --nocapturejust pre-pr