Repository navigation
feat(rg): add compatibility flag aliases - #1671
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 288768c | Commit Preview URL | May 22 2026, 10:41 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add more real-rg-compatible flag aliases and negations to the rg builtin: - negations for fixed strings, text/binary mode, column, byte offset, json, stats, trim, max-columns-preview, include-zero, and sort-files - aliases/no-op compatibility flags for --passthrough, -0, -., -L, and one-file-system/buffering/follow variants - differential test cases covering the new accepted flags against real rg ## Why This closes more CLI compatibility gaps where real rg accepts common aliases or later negations, but bashkit rg rejected or kept earlier state. ## How Extend the rg argument parser and help text, track explicit line-number requests so --column --no-column mirrors real rg, and add data-driven differential cases. ## Risk - Low - Parser-only behavior changes plus focused output parity tests. Symlink following and one-file-system remain accepted no-ops. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered Validation: - cargo fmt && cargo test -p bashkit builtins::rg::tests -- --nocapture - just pre-pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add more real-rg-compatible flag aliases and negations to the rg builtin:
Why
This closes more CLI compatibility gaps where real rg accepts common aliases or later negations, but bashkit rg rejected or kept earlier state.
How
Extend the rg argument parser and help text, track explicit line-number requests so --column --no-column mirrors real rg, and add data-driven differential cases.
Risk
Checklist
Validation: