Repository navigation
feat(rg): add color and engine compatibility flags - #1672
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | b1454b8 | Commit Preview URL | May 22 2026, 11:03 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add another real-rg compatibility batch: - accept -j/--threads as validated no-op thread controls - accept --colors, --regex-size-limit, and --dfa-size-limit value flags - accept Unicode and PCRE2 Unicode toggles as no-op compatibility flags - add -p/--pretty output behavior for heading plus line numbers when color is disabled - add --pcre2-version output for the pinned ripgrep 15.1.0 target - extend help output and data-driven real-rg differential cases ## Why These are common rg flags that should not fail simple searches in bashkit. The real-rg target is pinned in CI, so parity tests stay stable. ## How Extend the rg parser, help/version fast paths, and data-driven differential matrix. Flags that affect threading, color, regex engine internals, or resource tuning are accepted without changing search execution except --pretty's visible heading/line-number behavior. ## Risk - Low - Mostly parser/help behavior; output-affecting --pretty is covered against real rg with --color=never. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered Validation: - cargo fmt && cargo test -p bashkit builtins::rg::tests -- --nocapture - just pre-pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add another real-rg compatibility batch:
Why
These are common rg flags that should not fail simple searches in bashkit. The real-rg target is pinned in CI, so parity tests stay stable.
How
Extend the rg parser, help/version fast paths, and data-driven differential matrix. Flags that affect threading, color, regex engine internals, or resource tuning are accepted without changing search execution except --pretty's visible heading/line-number behavior.
Risk
Checklist
Validation: