Repository navigation
feat(rg): add null-data record search - #1673
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 8f02040 | Commit Preview URL | May 22 2026, 11:32 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add real `rg --null-data` support for NUL-delimited input records and output record terminators, plus `--stop-on-nonmatch` behavior. ## Why Continue closing parity gaps between bashkit `rg` and real ripgrep. ## How - Split searched content on NUL records when `--null-data` is set. - Use NUL output record terminators for match, count, context, heading, and file-list output paths where real rg does. - Stop a file search after a non-matching record follows a prior match for `--stop-on-nonmatch`. - Add data-driven differential cases against pinned real `rg`. ## Risk - Low / Medium - Output framing changes are scoped to `rg --null-data`; context and heading formatting are the main compatibility surface. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered Validation: - `cargo fmt && cargo test -p bashkit builtins::rg::tests -- --nocapture` - `just pre-pr`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add real
rg --null-datasupport for NUL-delimited input records and output record terminators, plus--stop-on-nonmatchbehavior.Why
Continue closing parity gaps between bashkit
rgand real ripgrep.How
--null-datais set.--stop-on-nonmatch.rg.Risk
rg --null-data; context and heading formatting are the main compatibility surface.Checklist
Validation:
cargo fmt && cargo test -p bashkit builtins::rg::tests -- --nocapturejust pre-pr