Repository navigation
feat(rg): add context separator controls - #1674
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 54940bc | Commit Preview URL | May 22 2026, 12:05 PM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add `rg --no-context-separator` and real-rg separator escape decoding for `--context-separator`, `--field-match-separator`, and `--field-context-separator`. ## Why Continue closing `rg` parity gaps around context output formatting. ## How - Track context separator suppression separately from empty separator strings, matching real rg behavior. - Decode common separator escapes like `\t`, `\r`, `\n`, `\\`, and valid `\xNN`. - Add data-driven differential tests with discontiguous context groups so separators are actually exercised. ## Risk - Low / Medium - Scoped to rg context/field output formatting; separator byte handling is the main compatibility surface. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered Validation: - `cargo fmt && cargo test -p bashkit builtins::rg::tests -- --nocapture` - `just pre-pr`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
rg --no-context-separatorand real-rg separator escape decoding for--context-separator,--field-match-separator, and--field-context-separator.Why
Continue closing
rgparity gaps around context output formatting.How
\t,\r,\n,\\, and valid\xNN.Risk
Checklist
Validation:
cargo fmt && cargo test -p bashkit builtins::rg::tests -- --nocapturejust pre-pr