Repository navigation
feat(rg): follow symlink search paths - #1675
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 8a2ad3b | Commit Preview URL | May 22 2026, 12:45 PM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add real rg-style symlink handling for `rg`: explicit symlink file/directory paths are searched, and recursive directory entries are followed when `-L`/`--follow` is set. `--no-follow` restores the default behavior. ## Why Previously `-L`/`--follow` was accepted as a no-op, so recursive searches missed symlinked files and directories that real ripgrep includes. ## How - Track logical display paths separately from actual read paths during recursive walks. - Resolve explicit symlink paths before classifying them as files or directories. - Follow symlink entries during recursive walks only when follow mode is enabled, with ancestor checks to avoid cycles. - Disable indexed search when follow mode is enabled so symlink traversal stays faithful to the VFS walk. - Add data-driven real-rg differential symlink cases. ## Risk - Medium - Recursive rg now reads symlink targets under `-L`; cycle handling and VFS path resolution are covered by new differential tests and existing security tests. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered Validation: - `cargo test -p bashkit --lib builtins::rg::tests -- --nocapture` - `just pre-pr`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add real rg-style symlink handling for
rg: explicit symlink file/directory paths are searched, and recursive directory entries are followed when-L/--followis set.--no-followrestores the default behavior.Why
Previously
-L/--followwas accepted as a no-op, so recursive searches missed symlinked files and directories that real ripgrep includes.How
Risk
-L; cycle handling and VFS path resolution are covered by new differential tests and existing security tests.Checklist
Validation:
cargo test -p bashkit --lib builtins::rg::tests -- --nocapturejust pre-pr