Repository navigation
feat(rg): accept preprocessor controls - #1677
Merged
Merged
Conversation
chaliy
marked this pull request as ready for review
May 22, 2026 13:44
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 5970cf6 | Commit Preview URL | May 22 2026, 01:45 PM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add rg parser/help support for --pre, --pre-glob, and --no-pre, with no-op parity for cat/empty preprocessors and explicit rejection for unsupported transforming preprocessors. ## Why These are real ripgrep flags and common enough that scripts should not fail just because the flags are present when preprocessing is effectively disabled/no-op. ## How Track the selected preprocessor during rg option parsing, consume and validate --pre-glob syntax, clear preprocessing with --no-pre, update help output, and add real-rg differential cases for cat, empty preprocessor, pre-glob, and --no-pre override behavior. ## Risk - Low - Arbitrary transforming preprocessors remain unsupported and return an explicit error instead of silently searching untransformed content. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add rg parser/help support for --pre, --pre-glob, and --no-pre, with no-op parity for cat/empty preprocessors and explicit rejection for unsupported transforming preprocessors.
Why
These are real ripgrep flags and common enough that scripts should not fail just because the flags are present when preprocessing is effectively disabled/no-op.
How
Track the selected preprocessor during rg option parsing, consume and validate --pre-glob syntax, clear preprocessing with --no-pre, update help output, and add real-rg differential cases for cat, empty preprocessor, pre-glob, and --no-pre override behavior.
Risk
Checklist