Repository navigation
feat(rg): honor ascii regex mode - #1681
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 13ec1d3 | Commit Preview URL | May 22 2026, 04:48 PM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Adds real rg parity for --unicode/--no-unicode regex mode handling. ## Why --no-unicode was previously accepted as a no-op, so regex word classes and word boundaries still used Unicode behavior instead of real rg's ASCII mode. ## How - Tracks Unicode regex mode in rg options and passes it to RegexBuilder. - Skips indexed regex search when --no-unicode needs ASCII regex semantics the index cannot represent. - Adds unit and differential tests for non-ASCII \w and -w behavior against real rg. - Updates help text to describe --unicode/--no-unicode as real regex mode flags. ## Risk - Low - Could affect searches using --no-unicode with regex syntax, which is the intended parity change. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds real rg parity for --unicode/--no-unicode regex mode handling.
Why
--no-unicode was previously accepted as a no-op, so regex word classes and word boundaries still used Unicode behavior instead of real rg's ASCII mode.
How
Risk
Checklist