Repository navigation
feat(rg): gate preprocessors with pre-glob - #1682
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 63f795b | Commit Preview URL | May 22 2026, 05:12 PM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Makes rg apply unsupported preprocessor validation per searched file, respecting `--pre-glob`. ## Why Real rg only runs `--pre` for files matched by `--pre-glob`. Bashkit previously rejected unsupported preprocessors during option parsing, even when the preprocessor would not apply. ## How - Stores `--pre-glob` rules on `RgOptions`. - Moves unsupported `--pre` validation into file read/search. - Propagates recursive file preprocessor errors through `RgCollectedInputs`. - Disables indexed search when a preprocessor is configured. - Adds unit and differential coverage for excluded vs included preprocessor globs. ## Risk - Low / Medium - Recursive search error propagation changed for preprocessor-related reads, but default/no-pre behavior remains unchanged. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes rg apply unsupported preprocessor validation per searched file, respecting
--pre-glob.Why
Real rg only runs
--prefor files matched by--pre-glob. Bashkit previously rejected unsupported preprocessors during option parsing, even when the preprocessor would not apply.How
--pre-globrules onRgOptions.--prevalidation into file read/search.RgCollectedInputs.Risk
Checklist