Repository navigation
feat(rg): honor global git ignore files - #1685
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 1fbcb8d | Commit Preview URL | May 22 2026, 06:23 PM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Adds rg support for global git ignore discovery during recursive searches. ## Why Real rg applies global git ignore rules from `core.excludesFile` or the default git ignore file for recursive roots in git repositories, and `--no-ignore-global` disables that behavior. Bashkit accepted those flags but did not model the behavior. ## How - Loads `core.excludesFile` from `$HOME/.gitconfig`, falling back to `$XDG_CONFIG_HOME/git/ignore` or `$HOME/.config/git/ignore` when no configured excludes file exists. - Applies global ignore rules per recursive root only when the root is in a git repo, unless `--no-require-git` is set. - Keeps explicit file searches unaffected, matching real rg ignore behavior. - Adds env-aware data-driven differential cases against real rg plus unit coverage. ## Risk - Low / Medium - Recursive rg output changes when the virtual environment contains HOME/XDG global git ignore files; explicit file paths still bypass ignore filtering. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds rg support for global git ignore discovery during recursive searches.
Why
Real rg applies global git ignore rules from
core.excludesFileor the default git ignore file for recursive roots in git repositories, and--no-ignore-globaldisables that behavior. Bashkit accepted those flags but did not model the behavior.How
core.excludesFilefrom$HOME/.gitconfig, falling back to$XDG_CONFIG_HOME/git/ignoreor$HOME/.config/git/ignorewhen no configured excludes file exists.--no-require-gitis set.Risk
Checklist