Repository navigation
feat(rg): parse separator escapes as bytes - #1695
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 4bd7027 | Commit Preview URL | May 23 2026, 12:09 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Parses rg separator escape sequences as bytes before decoding to Bashkit text output. ## Why Real rg treats `\xNN` in separator flags as raw bytes. The previous parser converted those bytes directly to Unicode scalar values, which diverged for high bytes and escaped UTF-8 byte sequences. ## How - Builds separator values as bytes, then decodes with UTF-8 lossiness to match the differential harness output model. - Keeps existing ASCII escapes unchanged. - Adds byte-exact real-rg differential cases for high-byte and escaped UTF-8 separators. ## Risk - Low / Medium - Affects custom rg field/context separator escape handling. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Parses rg separator escape sequences as bytes before decoding to Bashkit text output.
Why
Real rg treats
\xNNin separator flags as raw bytes. The previous parser converted those bytes directly to Unicode scalar values, which diverged for high bytes and escaped UTF-8 byte sequences.How
Risk
Checklist