Repository navigation
feat(rg): validate sort choices - #1698
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 0c60fe1 | Commit Preview URL | May 23 2026, 01:17 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Validate `rg --sort` and `rg --sortr` values against real ripgrep's accepted choice set. ## Why Real rg exits 2 for unknown sort choices. Bashkit previously accepted any value and searched anyway. ## How - Add `parse_sort_value` for `path`, `modified`, `accessed`, `created`, and `none`. - Convert rg option parse failures into rg-style `ExecResult` errors with exit code 2. - Add data-driven real-rg differential cases for invalid `--sort` and `--sortr` values. - Update direct rg error tests to assert stderr/exit-code behavior. ## Risk - Low - Affects rg option parsing and invalid-argument error surfacing. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Validate
rg --sortandrg --sortrvalues against real ripgrep's accepted choice set.Why
Real rg exits 2 for unknown sort choices. Bashkit previously accepted any value and searched anyway.
How
parse_sort_valueforpath,modified,accessed,created, andnone.ExecResulterrors with exit code 2.--sortand--sortrvalues.Risk
Checklist