Repository navigation
feat(rg): support ansi color numbers - #1700
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 367c870 | Commit Preview URL | May 23 2026, 01:55 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Support ripgrep-style 8-bit ANSI color numbers in rg --colors specs for foreground and background styles. ## Why Real rg accepts specs like match:fg:5 and emits 38;5;5 ANSI styling. Bashkit previously rejected those specs. ## How - Parse numeric color values as u8 ANSI 256-color indexes. - Emit 38;5;<n> for foreground and 48;5;<n> for background. - Add real-rg differential cases for numeric foreground and background colors. ## Risk - Low - Limited to rg --colors parsing and ANSI rendering. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Support ripgrep-style 8-bit ANSI color numbers in rg --colors specs for foreground and background styles.
Why
Real rg accepts specs like match:fg:5 and emits 38;5;5 ANSI styling. Bashkit previously rejected those specs.
How
Risk
Checklist