Repository navigation
feat(rg): support glob brace alternation - #1704
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 1256f2f | Commit Preview URL | May 23 2026, 03:14 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What
Add brace alternation support to rg glob matching.
## Why
Real ripgrep accepts glob alternates like *.{rs,toml}; bashkit rg
previously treated braces literally.
## How
- Parse top-level brace alternations in rg glob-to-regex conversion.
- Reuse nested glob conversion for each alternate.
- Add real-rg differential coverage for --glob and --type-add brace
alternation.
## Risk
- Low
- Affects rg glob filtering, ignore/pre-glob matching, and type glob
matching.
## Checklist
- [x] Tests added or updated
- [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add brace alternation support to rg glob matching.
Why
Real ripgrep accepts glob alternates like *.{rs,toml}; bashkit rg previously treated braces literally.
How
Risk
Checklist