Repository navigation
feat(rg): support escaped glob metacharacters - #1705
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 674a03b | Commit Preview URL | May 23 2026, 03:33 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add rg glob parsing support for backslash-escaped glob metacharacters, including escaped star, question mark, bracket classes, and brace alternation syntax. ## Why Real ripgrep treats backslash in glob patterns as quoting the next glob character. Bashkit rg previously interpreted escaped metacharacters as active glob syntax, so patterns like `-g '\*.txt'` did not match literal filenames the way real rg does. ## How Teach the shared rg glob-to-regex translator to emit the next character literally after `\\`, and preserve escapes while parsing brace alternatives so escaped commas/braces do not affect alternation parsing. Add real-rg differential cases for escaped glob metacharacters. ## Risk - Low - Affects rg glob matching, type globs, and ignore glob translation through the shared converter. This should improve parity, but backslash-heavy patterns are the behavioral surface. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add rg glob parsing support for backslash-escaped glob metacharacters, including escaped star, question mark, bracket classes, and brace alternation syntax.
Why
Real ripgrep treats backslash in glob patterns as quoting the next glob character. Bashkit rg previously interpreted escaped metacharacters as active glob syntax, so patterns like
-g '\*.txt'did not match literal filenames the way real rg does.How
Teach the shared rg glob-to-regex translator to emit the next character literally after
\\, and preserve escapes while parsing brace alternatives so escaped commas/braces do not affect alternation parsing. Add real-rg differential cases for escaped glob metacharacters.Risk
Checklist