Repository navigation
feat(rg): complete real file types - #1718
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 6d32b7f | Commit Preview URL | May 23 2026, 05:50 PM |
chaliy
force-pushed
the
2026-05-22-rg-batch-39
branch
from
May 23, 2026 17:49
de58fe2 to
6d32b7f
Compare
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Complete real ripgrep type-list parity for the remaining default file types: `spark`, `spec`, `ssa`, `sv`, `svg`, `swig`, `systemd`, `taskpaper`, `tcl`, `tex`, `texinfo`, `textile`, `twig`, `typoscript`, `typst`, `usd`, `v`, `vb`, `vcl`, `verilog`, `vhdl`, `vimscript`, `wiki`, `xz`, `yacc`, `yang`, `z`, `zsh`, and `zstd`. ## Why Bashkit rg should match real `rg -t/--type` filters for all built-in type names from `rg --type-list`. ## How Add default globs from real ripgrep 15.1.0, add data-driven differential cases against `/opt/homebrew/bin/rg`, and verify no real type names remain missing. ## Risk - Low - Only expands type filter matching; existing behavior is unchanged. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered - [x] `cargo fmt && just pre-pr` passed locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Complete real ripgrep type-list parity for the remaining default file types:
spark,spec,ssa,sv,svg,swig,systemd,taskpaper,tcl,tex,texinfo,textile,twig,typoscript,typst,usd,v,vb,vcl,verilog,vhdl,vimscript,wiki,xz,yacc,yang,z,zsh, andzstd.Why
Bashkit rg should match real
rg -t/--typefilters for all built-in type names fromrg --type-list.How
Add default globs from real ripgrep 15.1.0, add data-driven differential cases against
/opt/homebrew/bin/rg, and verify no real type names remain missing.Risk
Checklist
cargo fmt && just pre-prpassed locally