[niemyjski]

Add personal email alerts when a project or stack reaches a configured event count within a time window. Users can create, edit, disable, snooze, resume, and delete rules in account notification settings. Shared minute counters, cooldowns, and delivery-time access checks limit duplicate or stale alerts. The latest integration with main migrates the rate-notification feature, generated-model imports, and test mock to package subpath imports. Root email routes and tenant-isolated cleanup coverage are preserved.

Validation: Release build (0 warnings/errors), 71 focused backend tests, 12 rate-notification frontend tests, frontend validation/build, and Helm lint passed. Hosted checks for head 29157157f are queued; ship readiness remains blocked until they pass. Local service-backed and browser checks were not rerun for this integration; earlier successful runs do not verify the current head.

API behavior and implementation details

• Add CRUD and snooze/resume endpoints under /api/v2/users/{userId}/projects/{projectId}/rate-notifications and has_rate_notifications on project responses.
• Evaluation and the UI require premium access plus the rate-notifications organization feature. Rules survive downgrade or feature removal; membership removal and project/organization deletion clean up owned rules.
• Delivery rechecks rule version, membership, email verification/preferences, and the shared project notification budget. Distributed locking coordinates counter-plan fills and invalidation.
• Evaluation allows a full minute for in-flight writes to settle, adding one minute of alert latency. Emails use the typed Razor renderer and shared application URL builder.
• Current focused backend coverage includes counter behavior, cross-replica invalidation, evaluator concurrency, pipeline eligibility, serialization, and email rendering. Cleanup tests now assert both removal and preservation of another tenant's rules/cache.
• Integrated main through 1326f7463ef2ef52d637adcad1a028e405ab5505. No breaking API changes.

[niemyjski]

@github-copilot review

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[niemyjski]

Follow-up audit complete

Audited live head 862ad4ffe0f7406e541c36d944d08d39a80c5d13 against origin/main dc940dd15c8d222d9764080622fdf4583d4546b8, every GitHub feedback surface, and the complete effective diff using the thermo-nuclear code-quality review.

Feedback classification

• Three github-code-quality inline findings are resolved, outdated, already fixed, and superseded by the architecture pivot. The criticized rule-filtering loop no longer exists; RateNotificationCounterPlan.GetCounterKeys(...) now compiles signal/stack eligibility centrally and ingestion iterates only matching counter keys.
• Copilot's submitted review contains no finding; the reviewer reported an internal error. It is non-actionable.
• No human reviewer submitted a finding. The top-level Copilot review request is administrative, not feedback.
• The current coverage comment is informational and green: 77% line / 66% branch.
• Live result: 0 unresolved review threads and 0 unresolved actionable findings.

Thermo-nuclear finding and RCA

The evaluator producer and delivery consumer independently formatted the queued SubjectKey. That duplicated a protocol invariant across process boundaries; a future one-sided edit could enqueue valid notifications that delivery silently rejected.

Commit 862ad4ffe centralizes project/stack subject-key construction in the existing rate-notification counter plan and uses it from both evaluator and delivery. Focused regression coverage proves both subject scopes. No other actionable correctness, authorization, serialization, concurrency, non-atomic update, file-size, or unnecessary orchestration issue remained after the complete diff audit.

Product/UI dogfood

Dogfooded the exact PR runtime on desktop (1280x720) and mobile (390x844): empty state, create, edit threshold, snooze, resume, disable, and delete all succeeded. The UI states the cost-saving purpose, provides a useful 10 errors / 5 minutes / 30-minute cooldown starting point, and keeps actions usable at both viewports. The committed Playwright scenario independently passed.

Verification

• dotnet test ... --filter-class Exceptionless.Tests.Pipeline.UpdateRateCountersActionTests — 11 passed
• dotnet test ... --filter-class Exceptionless.Tests.Jobs.RateNotificationEvaluatorJobTests — 10 passed
• dotnet test ... --filter-class Exceptionless.Tests.Jobs.RateNotificationsJobTests — 19 passed
• dotnet test Exceptionless.slnx --no-restore --no-build — 2,608 total; 2,606 passed; 2 intentional skips; 0 failed
• dotnet build Exceptionless.slnx --no-restore — succeeded; 0 warnings; 0 errors
• focused dotnet format --verify-no-changes — passed
• rate-notification Vitest files — 2 files / 12 tests passed
• local Playwright rate-notification E2E — 1 passed
• git diff --check — passed
• GitHub required checks on 862ad4ffe — version, test-client, test-e2e, test-api/coverage, docker-build, and CLA all passed

No external blocker remains.

[niemyjski]

Final follow-up on head 1a9cbe377e3bb7ff70f20eb7b12578f545e13905:

• Re-audited all review threads, reviews, and conversation: the three inline findings remain resolved/outdated and superseded by RateNotificationCounterPlan; no new actionable feedback appeared.
• Commit 50d919437 fixes the failing test-client check by restoring deterministic class/module sort order in e2e/fixtures/api-client.ts without behavior changes.
• Merged current main normally in 1a9cbe377 to satisfy strict up-to-date branch protection; no rebase or force-push.
• Post-push local validation: npm run lint, npm run check (0 errors/warnings), npm run build, and git diff --check all pass.
• Final GitHub run 31624111842: version, test-client, test-api/coverage, test-e2e (Aspire + Playwright), docker-build, and CLA all passed; publish/deploy jobs skipped as expected for a PR.

Final state: open, current with main, mergeable, CLEAN, zero unresolved review threads.

[niemyjski]

Thermo-nuclear follow-up on head 002497e:

Commit 002497e applies the surgical review fixes: removes the resurrected migration cron resume, aligns the canonical email source with singular/plural rendering, reuses the E2E polling helper, restores PUT stack-scope validation parity, centralizes supported-window policy across API/runtime, makes active-key discovery precede increments, memoizes duplicate bucket reads, and aligns generated nullable-enum schemas with the API contract.

Static evidence: git diff --check passed; OpenAPI and endpoint-manifest JSON parse; source/compiled template placeholders and generated TypeScript/Zod nullability agree. The contract generator could not run because this isolated worktree has no installed swagger-typescript-api. Per the explicit review constraint, no local tests, builds, Aspire, E2E, browser, runtime services, or dogfood were run, so these fixes are not locally test-verified. Two deeper non-surgical findings remain as inline review threads.

[github-actions]

Package	Line Rate	Branch Rate	Complexity	Health
Exceptionless.AppHost	23%	22%	130	❌
Exceptionless.Core	78%	70%	11359	✔
Exceptionless.Insulation	51%	43%	370	➖
Exceptionless.Web	87%	72%	9601	✔
Summary	81% (29445 / 36361)	70% (14738 / 20996)	21460	✔