Repository navigation
Conversation
|
|
|
Follow-up reviewer and thermo-nuclear audit complete at Feedback inventory:
Validation and RCA:
Thermo-nuclear review:
Verification:
No additional code change or push was needed in this follow-up. The only remaining merge blocker is administrative: the PR is still draft and |
|
Final live follow-up completed at head 980301b. Feedback disposition:
Current verification:
No commit or push was made because the live feedback and effective-diff audit found no surgical change to apply. The PR remains draft and BLOCKED only by the pending CLA status. |
Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>
638e8fb to
feeaa5d
Compare
# Conflicts: # src/Exceptionless.Job/appsettings.Staging.yml # src/Exceptionless.Web/appsettings.Staging.yml
Closes #1526
Configure infrastructure once using technology-named connection strings while retaining legacy role selectors. A shared resolver preserves native Redis strings and RabbitMQ URIs, applies fixed provider priorities and explicit
localoverrides, and preserves structured-setting precedence. Redis connections are shared only for identical effective strings, preventing one role's endpoint from leaking into another.EX_variables consistently override ordinary and Aspire variables.Validation at
e2d0475f8, including current main1326f7463: 80 focused tests, Release solution build (zero warnings/errors), documentation checks/build and four tests, link/assets audit, Helm lint/template rendering, and diff checks passed. New hosted checks are pending.Remaining gates: service-backed local dogfooding is incomplete and the Copilot contributor's CLA check remains pending. Draft status is preserved. No API contracts change. During rolling upgrades, keep providers and effective connection strings unchanged. Applying the bundled Redis/Elasticsearch pod-template changes replaces those pods once; custom selectors using the removed pod
chartlabel need updating.Verification and implementation details
dotnet test --project tests/Exceptionless.Tests/Exceptionless.Tests.csproj --configuration Release -- --filter-class 'Exceptionless.Tests.Configuration.*'— 77 passed.Exceptionless.Tests.BootstrapperTests— 3 passed.dotnet build Exceptionless.slnx --configuration Release --no-restore.deno task checkanddeno task verify. Website CI uses Deno 2.9.7 for Lume 3.3 compatibility.helm lint k8s/exceptionlessandhelm template pr2273 k8s/exceptionless.