Repository navigation
Conversation
|
|
niemyjski
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6d3929e96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Follow-up reviewer-feedback and thermo-nuclear audit completed against live head Feedback classification:
The complete five-file branch-vs-main diff also passed the requested thermo-nuclear structural review: no spaghetti/branch growth, boundary leak, duplicate canonical helper, cast/optionality churn affecting correctness, non-atomic update, unnecessary sequential orchestration, or 1,000-line threshold crossing. The 19-line header component earns its boundary by centralizing and testing the accessible pressed-state interaction; no safe code-judo simplification remains beyond removing the unsupported First mode. Verification on the live head:
No follow-up code change was required. The sole remaining blocker is the pending external Copilot contributor CLA. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69b976ee9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97ebf34593
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>
976b251 to
07f054e
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07f054e3f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc8a2bebf9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const [sort, label, mode, explicitSort] of [ | ||
| ['-events', 'Events', 'stack_frequent', false], | ||
| ['-last', 'Last', 'stack_recent', false], | ||
| ['-events', 'Events', 'stack_frequent', true], | ||
| ['-last', 'Last', 'stack_recent', true] |
There was a problem hiding this comment.
Each entry in this loop becomes a separate Playwright test, so e2eScenario provisions and deletes an organization and project four times; with one worker per browser shard, these variants serialize the same reset/save journey and add repeated service setup to the CI critical path. Keep one representative browser journey and move the alias matrix to Vitest, or exercise the variants with test.step under a single fixture.
AGENTS.md reference: src/Exceptionless.Web/ClientApp/AGENTS.md:L27-L29
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in ae96423: all four alias variants now run as named test.step cases under one e2eScenario fixture, with unique saved-view slugs. All reset/save assertions remain. Focused tests, validation, and production build pass; Playwright discovers the consolidated journey. Leaving this thread open until fresh browser execution verifies it.
|
Adds descending Events and Last controls to the Svelte stack table. Sorting survives reloads and saved views, resets pagination and selection, and preserves legacy aliases when saving unrelated settings. Existing API modes preserve the matching result set; First and Duration remain non-sortable.
Latest main is integrated, preserving environment filtering and current import conventions. The four saved-view alias cases now share one browser fixture while retaining their assertions.
Validation: 10 focused tests, formatting/type/lint validation, production build, and diff checks passed. Fresh hosted CI and local browser QA remain pending; the contributor CLA remains an outstanding gate. No backend API or breaking changes.