Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
niemyjski
reviewed
Oct 15, 2026
| Keep this direct reference on the latest 2.x release until ASP.NET Core supports 3.x. --> | ||
| <PackageReference Include="Microsoft.OpenApi" Version="2.12.2" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="11.0.0-rc.2.26504.105" /> | ||
| <PackageReference Include="Microsoft.OpenApi" Version="3.10.2" /> |
Member
There was a problem hiding this comment.
we should be able to get rid of this now
Target net11.0 with SDK 11.0.100-rc.2.26504.105 across projects, CI, Docker images, and dev tooling, and move framework-aligned packages to 11.0.0-rc.2. Microsoft.AspNetCore.OpenApi 11 requires Microsoft.OpenApi 3.x, so adapt the transformers to the media type interfaces and keep the published document on OpenAPI 3.1. Refresh Foundatio, test SDK, and time provider testing packages. Drop the Microsoft.Extensions.Logging.Abstractions reference now that it ships in the shared framework, and disable static web assets in the test project so the Web and Job dotnet-watch assets added in RC2 don't collide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ejsmith
force-pushed
the
feature/net11-rc2
branch
from
October 15, 2026 02:02
521b460 to
00a3508
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the app to .NET 11 RC2 (SDK
11.0.100-rc.2.26504.105, runtime11.0.0-rc.2.26504.105, released 2026-10-13) and refresh the other .NET dependencies that upgrade cleanly. All projects targetnet11.0.global.json, CI, the Dockerfile, the dev container, VS Code launch paths, the CI shard runner, and the email-template preview script all point at .NET 11. Public routes, persisted data, and config keys are unchanged.Validation: Release build with warnings as errors, plus the full backend suite: 3,336 tests, 3,333 passed, 0 failed, 3 existing opt-in/performance skips. The
jobandapiDocker targets build and run on the RC2 images. NuGet reports no vulnerable direct or transitive packages.Changes, review notes, and verification
Package updates
11.0.0-rc.2.26504.105[3.10.2, 4.0.0)). Request body content now usesIOpenApiMediaType, so two transformers construct and mutate the concreteOpenApiMediaType(upgrade guide).These stay put: Aspire 13.6.1 and OpenTelemetry 1.19.x are already the latest. Foundatio.Repositories stays on its pinned preview build. Serilog, Riok.Mapperly, and Stripe have only prerelease updates.
OpenAPI contract
swagger-typescript-api) and third-party generators read this document, soOpenApiVersionis pinned to 3.1. Microsoft.OpenApi 3.x writes that as3.1.2.openapi.jsonwas regenerated. Ignoring the version, the server URL's dropped trailing slash, and the ordering of response codes and tags, it is semantically identical to the previous snapshot. No route, schema, or response changes.Build workaround: static web assets in the test project
RC2 adds dotnet-watch browser-tools assets (
_framework/Microsoft.NET.Sdk.BlazorWeb.DotNetWatch*) to every Web SDK project. The test project is a Web SDK project that references both Web and Job, so their identical assets collide. The Debug build then fails with "Conflicting assets with the same target path" or "scoped css bundles do not have matching endpoints".The tests serve
wwwrootfrom the Web content root, throughUseSolutionRelativeContentRootandUseStaticFiles, so the test project now setsStaticWebAssetsEnabled=false. This looks like an SDK regression and can be revisited at GA.EnableHotReloadInRuntimeConfigDevFile=falsewould also work, but it would turn off C# hot reload as well.Runtime behavior changes reviewed
(decimal)0.1is now0.1000000000000000055511151231. Session durations use this cast (PersistentEventExtensions.UpdateSessionStart). Elasticsearch already stores event values at double precision, and a round trip returns230.131079, so stored data is unchanged.CloseInactiveSessionsJobTestswas relying on the old 15-digit rounding and now compares at the stored double precision.IHost.RunAsyncnow throws when aBackgroundServicefails. The existingProgram.Maincatch blocks now log Fatal and exit with code 1 instead of 0.http.server.request.durationgainserror.type, andActivity.StatusDescriptionis no longer set for unhandled exceptions. Dashboards or alerts keyed on those may need adjusting.Content-Length/Transfer-Encodingand HTTP/2 connection headers. Low risk behind the ingress.sdk:11.0.100-rc.2andaspnet:11.0.0-rc.2images are Ubuntu 26.04 and still run as root on port 8080. NodeSourcesetup_22.xworks there. The all-in-one image installs the RC2 runtime on the Ubuntu 24.04 Elasticsearch base, wherelibicu74is still correct and the x64/arm64 payloads resolve. .NET 11 requires x86-64-v2 on x64.Verification
The full
appand all-in-oneexceptionlessDocker targets were not built locally. CI's Docker job covers them.🤖 Generated with Claude Code