feat(store): add bucket lifecycle support#847
Open
mping-exo wants to merge 5 commits into
Open
Conversation
020c155 to
1ff974f
Compare
Contributor
|
Thanks for your contribution, in grand scheme of things lgtm, I have one tiny issue with some enum handling in the default case, will leave a comment in the code directly. I'm also wondering if the dep bump could have been separated from the feature, separate PRs. |
f790f58 to
5ced9eb
Compare
5ced9eb to
2fb2f45
Compare
natalie-o-perret
approved these changes
Jun 30, 2026
natalie-o-perret
left a comment
Contributor
There was a problem hiding this comment.
The nit test can be done later in a follow-up pr, not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
falsevalue because they were missing this old check vs new checkChecklist
(For exoscale contributors)
CHANGELOG.md)Testing
get/show/delete config
expiration header