[codex] harden atomic writes and checks - #1
Merged
Conversation
explicit09
marked this pull request as ready for review
May 19, 2026 04:30
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MoveFileExW.Root Cause
The previous atomic-write fallback could delete an existing destination before renaming the temp file on Windows-like rename semantics. A crash or second rename failure could leave branch refs or objects missing. Ref temp files were also created in
refs/heads, so stale crash leftovers could appear as branches.Validation
cargo test --workspace --exclude vedit-pycargo clippy --workspace --exclude vedit-py -- -D warningscargo fmt --checkcargo check -p vedit-core --target x86_64-pc-windows-msvcgit diff --check