Skip to content

[codex] Address post-merge review feedback - #29

Open
explicit09 wants to merge 1 commit into
mainfrom
codex/address-post-merge-review
Open

[codex] Address post-merge review feedback#29
explicit09 wants to merge 1 commit into
mainfrom
codex/address-post-merge-review

Conversation

@explicit09

Copy link
Copy Markdown
Owner

Summary

  • Addresses late Codex review feedback left on merged PRs [codex] Fix changed clip ID merge contract #26 and [codex] Add multi-author commit attribution #28.
  • Preserves explicit author as the primary author when deserializing mixed-format commit JSON.
  • Fixes changed-clip-ID merge edge cases:
    • unidentified clips now count toward positional move detection,
    • consecutive trailing source changes keep source order,
    • stale transitions/gaps adjacent to source-deleted clips are removed.

Review Threads Addressed

Validation

  • Added regression tests that failed before the fixes.
  • cargo test

@explicit09

Copy link
Copy Markdown
Owner Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant