fix(ci): improve builds by gitignoring go-coverage.out - #1747
Merged
Conversation
.gitignore listed `coverage.out`, but both workflows pass `-coverprofile=go-coverage.out`, so the profile was left untracked on every run that produced it — a name mismatch that has been there as long as the entry. Harmless while nothing looked at git state, but it makes the working tree dirty, and a build step that inspects git will refuse to proceed rather than stamp a commit that does not describe what was built. ko does exactly that once given a build config, so this becomes load-bearing shortly. Verified by reproducing the docker job's file state in order — go test, the cobertura conversion, and the downloaded ui/build artifact — and confirming git status is clean afterwards. The other two were already covered: go-cobertura.xml by name, ui/build/** by ui/.gitignore. Also ignores *.tsbuildinfo, which tsc emits for the composite tsconfig.node.json project. Not produced by CI today — `yarn build` is just `vite build` — but it is the same class of stray artifact. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Code Coverage OverviewLanguages: TypeScript, Go TypeScript / code-coverage-agentThe overall line coverage in commit 08260e8 in the Show a line coverage summary of the most impacted files.
Go / code-coverage-agentThe overall line coverage in commit 08260e8 in the Show a line coverage summary of the most impacted files.
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line
.gitignorefix for a name mismatch that has been there as long as the entry.The mismatch
.gitignorelistscoverage.out, but both workflows pass a different filename:So the coverage profile is left untracked on every run that produces it, in both
build.yamlanddocker-workflow.yml.Why it matters
Harmless while nothing looks at git state. But it makes the working tree dirty, and a build step that inspects git will refuse to proceed rather than stamp a commit that does not describe what was built.
kodoes exactly that once given a build config, failing with:Landing this separately so the fix is available independently of the change that surfaced it.
Verified
Reproduced the docker job's file state in the order the steps run —
go test, the cobertura conversion, and the downloadedui/buildartifact — then confirmedgit status --porcelainis clean:go-coverage.outgo-cobertura.xmlui/build/**ui/.gitignoreAlso
Ignores
*.tsbuildinfo, whichtscemits for the compositetsconfig.node.jsonproject. Not produced by CI today —yarn buildis justvite build— but it is the same class of stray artifact, and any step that runstscbefore a git-inspecting build would hit the same failure.