Skip to content

Fix MSVC x86 prefetch architecture check - #4814

Open
lpyu001 wants to merge 1 commit into
facebook:devfrom
lpyu001:fix-msvc-x86-prefetch
Open

lpyu001 wants to merge 1 commit into
facebook:devfrom
lpyu001:fix-msvc-x86-prefetch

Conversation

@lpyu001

@lpyu001 lpyu001 commented Oct 4, 2026 •

Copy link
Copy Markdown

Fix the MSVC 32-bit x86 architecture check used for prefetch support.

MSVC defines _M_IX86 for x86 targets, not _M_I86. As a result, the current condition doesn't enable the _mm_prefetch
implementation for 32-bit MSVC builds.

The same issue was recently fixed in CPython after its prefetch logic, which was derived from zstd, was found to contain the same typo:

python/cpython#157907

@meta-cla

meta-cla Bot commented Oct 4, 2026

Copy link
Copy Markdown

Hi @lpyu001!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Oct 7, 2026
@meta-cla

meta-cla Bot commented Oct 7, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant