Repository navigation
Fix glob pattern budgets across exclusions - #244
Merged
facelessuser merged 1 commit intoOct 18, 2026
Merged
Conversation
Owner
|
@gir-bot lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glob.glob('a', exclude='b', limit=1)currently succeeds even though the include and exclusion expand to two patterns. The scanningGlobclass starts a new count for each group, so plain patterns and SPLIT expansions can exceed the shared limit. This is separate from the compilation and translation paths fixed in #243.Keep the expanded-pattern count on the
Globinstance across both groups. Only reduce the brace expansion allowance for positive limits, preserving unlimited expansion for zero and negative limits after an earlier pattern.Add regressions for
globandiglob, string and bytes inputs, include/exclude lists, repeated patterns, BRACE and SPLIT expansion, exact limits, and the implicit NODIR filter. Include a changelog entry.Validation on Windows / Python 3.12.8:
python -m ruff check .,python -m mypy, andgit diff --checkpass.The hosted operating-system/Python matrix and documentation build have not been run locally. AI tools assisted with implementation and review; the reproduction and checks were run locally.