updates to reporting for retests#141
Merged
Merged
Conversation
Adds a stagingClosed date to Vulnerability and threads it through the remediation workflow alongside the existing dev and prod closes: - Close in Staging action, modal, and notes on the Remediation Schedule and Verification Edit pages; Reopen clears the staging date - Status badges now show the close date for dev, staging, and prod - Closed (Staging) column on the Open Vulnerabilities table - Staging Closed row on the vulnerability detail panel - REST API setstatus accepts isClosedStaging/stagingClosedDate and now honors isClosedProd (was gated on isClosedDev by mistake) - DOCX reports support a closedInStagingAt template token - Manager dashboard vulnerability CSV export adds Closed Dev/Staging dates and per-environment closed booleans
The button had no click handler, so it silently did nothing. It now opens DownloadReport for the assessment's final report, or shows a notice when no report has been generated yet.
…gs in VulnerabilityDTO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Closed in Staging state to the remediation workflow, sitting alongside the existing dev and prod closes. Also fixes a dead report button on the retest verification page and adjusts a font size.
Changes
Closed in Staging workflow
stagingCloseddate toVulnerabilityand threads it through the remediation workflow.setstatusacceptsisClosedStaging/stagingClosedDateand now honorsisClosedProd(was incorrectly gated onisClosedDev).closedInStagingAttemplate token.Bug fix
DownloadReportfor the assessment's final report, or shows a notice when no report has been generated yet.Misc
Tests
ManagerDashboardVulnerabilitiesCSVTestcovering the new CSV export fields.