feat: support globPattern option for custom route matching in non-wildcard mode - #609
Open
lx3133584 wants to merge 1 commit into
Open
feat: support globPattern option for custom route matching in non-wildcard mode#609lx3133584 wants to merge 1 commit into
lx3133584 wants to merge 1 commit into
Conversation
…dcard mode Fixes fastify#178 Signed-off-by: Liang Xu <lx3133584@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
wildcard: falseto pre-register static routes,@fastify/statichardcodes the glob search pattern to'**/**', registering routes for every file found in the root directory. Users who want to restrict registered routes to specific extensions or subdirectories (e.g.'**/*.{css,js}') currently have to rely onglobIgnoreor custom routing workarounds.Root Cause
globinindex.jswas invoked with a hardcoded'**/**'pattern without exposing a configurable pattern option.Fix
globPatternoption inFastifyStaticOptions(defaulting to'**/**').opts.globPattern ?? '**/**'toglobwhenwildcard: false.types/index.d.tsand documentation inREADME.md.Testing
test/glob-pattern.test.jsverifying that customglobPatternonly registers matching files.node --test test/glob-pattern.test.js.