Skip to content

Track transactional commits in aiokafka monitor - #799

Open
wbarnha wants to merge 1 commit into
masterfrom
copilot/fix-166-transaction-commit-monitor
Open

wbarnha wants to merge 1 commit into
masterfrom
copilot/fix-166-transaction-commit-monitor

Conversation

@wbarnha

@wbarnha wbarnha commented Oct 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Notify the transport after a successful transactional offset commit.
  • Update aiokafka's commit-livelock timestamp on its consumer thread, eliminating false 'has not committed' warnings under exactly-once.
  • Add consumer and aiokafka regression tests.

Fixes #166.

Validation

  • Affected unit modules: 277 passed, 3 skipped.
  • Python 3.14 emitted existing resource/thread-shutdown warnings.

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.18%. Comparing base (3442a90) to head (3b489ca).

Files with missing lines Patch % Lines
faust/transport/consumer.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   96.20%   96.18%   -0.02%     
==========================================
  Files         110      110              
  Lines       11791    11803      +12     
  Branches     1282     1283       +1     
==========================================
+ Hits        11343    11353      +10     
- Misses        351      352       +1     
- Partials       97       98       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New error messages seen in faust app with aiokafka 0.7.1

1 participant