Repository navigation
Support aiokafka 0.15.0 - #803
Merged
Merged
Conversation
Replace the removed parse_kafka_version helper with packaging's Version for Kafka header support checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #803 +/- ##
==========================================
- Coverage 96.20% 96.19% -0.01%
==========================================
Files 110 110
Lines 11791 11789 -2
Branches 1282 1282
==========================================
- Hits 11343 11341 -2
Misses 351 351
Partials 97 97 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
aiokafka 0.15.0 removed
aiokafka.util.parse_kafka_version, causing Faust's aiokafka driver to fail during import. Replace that removed helper withpackaging.version.Versionwhen determining whether the configured Kafka version supports headers. This preserves existing behavior for Kafka versions below 0.11.NOTE: All patches should be made against master, not a maintenance branch like
3.1, 2.5, etc. That is unless the bug is already fixed in master, but not in
that version series.
If it fixes a bug or resolves a feature request,
be sure to link to that issue via (Fixes #4412) for example.