Skip to content

fix: update outbox dispatcher test expectations - #17

Open
fdaei wants to merge 1 commit into
mainfrom
fix/outbox-dispatcher-test-2623372964619808782
Open

fdaei wants to merge 1 commit into
mainfrom
fix/outbox-dispatcher-test-2623372964619808782

Conversation

@fdaei

@fdaei fdaei commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Update the assertions to expect 2 reminders (1h and 15m) instead of 1, because the booking starts in 2 hours and we omit the 24h reminder.


PR created automatically by Jules for task 2623372964619808782 started by @fdaei

The `BookingJobsService.scheduleBooking` function generates multiple reminders (1h, 15m) for a booking 2 hours away, not 1. This updates the `OutboxDispatcher` tests to reflect this reality and accurately assert the amount of inserted records instead of falsely testing for 1 reminder.

Co-authored-by: fdaei <81993335+fdaei@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant