Add four-platform Homebrew install acceptance for Formula PRs - #22
Merged
Conversation
Phase 9 of the release plan: release/fm-* PRs now run a native-runner matrix that installs the previous Formula from main, upgrades to the PR Formula, runs brew test, uninstalls, and verifies credentials survive upgrade and uninstall. Credentials are exercised against a loopback fake API with a sentinel token, on macOS inside a throwaway keychain (the default keychain and search list are restored afterwards) and on Linux in an isolated HOME. Verified end-to-end locally on macos-arm64 against the real 0.1.1 release assets. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Phase 9 of the release plan (the remaining gap): real install/upgrade/uninstall acceptance for Homebrew.
Changes
Verified locally (macos-arm64, real 0.1.1 assets)
```
ok: previous version 0.1.1 installed
ok: credential stored
ok: fm reports 0.1.1
ok: brew test passed
ok: command -v fm resolves into the Homebrew prefix
ok: command -v fm empty after uninstall
ok: credential survives uninstall
ok: credential survives reinstall
ok: logout removes the credential
ok: final uninstall leaves no fm
```
Two real-world findings folded into the script: the Security framework locates the default keychain via `HOME` (so HOME must stay real on macOS), and `security list-keychains -s` must be restored or subsequent lookups fail.