Repository navigation
chore: depend on @seamless-auth/types 0.34 - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@seamless-auth/messaging0.3.0 declares@seamless-auth/types^0.33.0 while the auth API, the server adapters and the OpenID Provider are on ^0.34.0, so the API installs two copies of types. This moves messaging to ^0.34.0.Types 0.34.0 adds
headers: Record<string, string>(optional) to the email message schema. That is the same shape messaging already added locally in 0.3.0 forList-Unsubscribe, and the header validation invalidation.tsis unchanged, soEmailMessageis now re-exported from types instead of intersected with a localheadersfield. The public type is identical.The three packages are a fixed group, so the patch changeset releases messaging, messaging-aws and messaging-twilio 0.3.1 together. The auth API picks them up in a follow-up PR.
Checks run locally (
npm run release:verify):npm run lint: passnpm run format:check: passnpm run typecheck: passnpm test: 12 tests pass