Repository navigation
feat: carry email headers through the messaging types - #255
Merged
Merged
Conversation
EmailMessage gains the optional headers record from types 0.34.0, and core hands an override's headers to the email transport untouched. The enrollment invite input now comes from types too, and express exports it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #253 (types 0.34.0).
EmailMessagefrom@seamless-auth/types0.34.0 has an optionalheadersrecord. Core now passes an override's headers to the email transport untouched, so an adopter can sendList-UnsubscribeandList-Unsubscribe-Post.@seamless-auth/messaging-aws0.3.0 sends them through SES v2 and validates the names and values.SendEnrollmentInviteEmailInputnow comes from types instead of a local interface in core. The Express, Fastify and Next.js adapters export it with the other messaging types.Tests: a core test that an override's headers reach the transport, and an Express consumer type fixture that takes
headersand rejects a non-string value.Changeset: core, express, fastify and nextjs minor. Merging this before #252 puts it in the same release as the types bump.
Checks: build, typecheck, lint, format:check, and tests (core 588, express 264, fastify 271, nextjs 257).