Repository navigation
fix: accept only refresh cookies in verifyRefreshCookie - #264
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every adapter cookie (pre-auth, registration, access, refresh) is an HS256 JWT signed with the same
cookieSecret.verifyRefreshCookiechecked only the signature, so any of them verified as a refresh cookie, andhasSeamlessSessionin@seamless-auth/nextjsreported a session when one sat in the refresh cookie slot.verifyRefreshCookienow also requires the refresh cookie's shape: a non-empty stringsub, a non-empty stringrefreshToken, and no upstreamtoken. Only refresh cookies carry a refresh token, and they never carry an upstream token, so the shape tells them apart without a new claim. Refresh cookies issued by earlier versions already have this shape, so existing sessions keep working.The silent refresh path (
refreshAccessToken) goes through the same function and gets the same check.Tests
packages/core/tests/verifyRefreshCookie.test.js: accepts a refresh cookie; refuses pre-auth, access, mixed, empty, non-string and subject-less payloads, and a foreign secretpackages/nextjs/tests/session.test.js:hasSeamlessSessionis false for a pre-auth or access cookie copied into the refresh slotThe new cases fail on
main(8 failures) and pass with the change.pnpm test: core 596, express 264, nextjs 259, fastify 271, all passing.pnpm check:types-currentpasses.